Air tank

I have the option to purchase a 3500 psi 100cf scuba tank for a good price. It has a 2020 hydro and will be filled upon purchase. I spoke with the local dive shop and they will fill as well as have the ability to do visual and hydro inspections on site. Other than the weight and lack of 4500 psi capability are there any downsides to going this route as opposed to carbon fiber SCBA tank which costs 3 times as much and is limited to 15 year life?



I will only be topping 240 cubic inch tank from 100 to 175 bar. 


 
You already answered your question as to what the downsides of a scuba tank are. The only good thing about buying a scuba tank is the relief and good riddance feeling after you sell it. The worst purchase I ever made in this sport was buying a scuba tank. An SCBA tank may cost 3 times more but it's 10 times more convenient. Cost isn't everything. A carbon fiber tank is a pleasure. A scuba tank is like dragging around a sack of cement. It's much bulkier, heavier, but much less fills so more frequent trips to the dive shop. I can't say strongly enough: Don't buy a scuba tank. Get a 4500 psi carbon fiber tank. 
 
For your purposes (175bar fills), the SCUBA tank could be a reasonable alternative to an SCBA tank.

That SCUBA tank will fill your gun more times than a 45min SCBA tank. The SCBA tank also costs a lot more and has a limited life, but it is lighter and easy to carry.

I used a 3300psi SCUBA tank for several years and it was fine until I got some new guns that filled to 250 and 310bar.

I assume you meant that you would be topping off a 240cc (not 240 cubic inch) airgun.